Skip to content

🎨 Only run a single function at a time in map endpoint #8327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2025
Merged

🎨 Only run a single function at a time in map endpoint #8327

merged 1 commit into from
Sep 8, 2025

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Sep 8, 2025 •
edited
Loading

What do these changes do?

  • Only trigger a single celery task at a time in map endpoint.
  • After running load tests it is clear, that (for now) we must run the functions sequentially in the api-server's map endpoint. Otherwise requests start failing.
  • This will make the map endpoint slow, but should increase robustness for now.
  • Future steps might be to use celery task groups or celery task map for this. Which should again increase performance

Related issue/s

How to test

Dev-ops

@bisgaard-itis bisgaard-itis self-assigned this Sep 8, 2025
@bisgaard-itis bisgaard-itis added this to the Cheops milestone Sep 8, 2025
@bisgaard-itis bisgaard-itis marked this pull request as ready for review September 8, 2025 13:12
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sanderegg sanderegg merged commit c500c52 into ITISFoundation:master Sep 8, 2025
56 of 57 checks passed
@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.02%. Comparing base (ffd604e) to head (75cdee7).
⚠️ Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (ffd604e) and HEAD (75cdee7). Click for more details.

HEAD has 31 uploads less than BASE
Flag BASE (ffd604e) HEAD (75cdee7)
unittests 32 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #8327       +/-   ##
===========================================
- Coverage   87.86%   69.02%   -18.84%     
===========================================
  Files        1945      880     -1065     
  Lines       75371    39315    -36056     
  Branches     1311      175     -1136     
===========================================
- Hits        66222    27137    -39085     
- Misses       8754    12121     +3367     
+ Partials      395       57      -338
Flag Coverage Δ *Carryforward flag
integrationtests 64.06% <ø> (ø) Carriedforward from ffd604e
unittests 91.91% <ø> (+5.39%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.07% <ø> (-8.14%) ⬇️
agent ∅ <ø> (∅)
api_server 91.91% <ø> (ø)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.06% <ø> (-12.96%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 81.87% <ø> (-8.59%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 58.95% <ø> (-29.06%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd604e...75cdee7. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 75cdee7.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@pcrespov pcrespov mentioned this pull request Sep 11, 2025
Closed
16 tasks
This was referenced Sep 18, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@wvangeit wvangeit Awaiting requested review from wvangeit wvangeit is a code owner

Assignees

@bisgaard-itis bisgaard-itis

Labels

a:apiserver api-server service Meta-modeling

Projects

None yet

Milestone

Cheops

Development

Successfully merging this pull request may close these issues.

3 participants

@bisgaard-itis @pcrespov @sanderegg